Skip to content

Commit

Permalink
Remove unused exception parameter from fbpcs/data_processing/id_combi…
Browse files Browse the repository at this point in the history
…ner/IdSwapMultiKey.cpp

Summary:
`-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it.

This:
```
try {
    ...
} catch (exception& e) {
    // no use of e
}
```
should instead be written as
```
} catch (exception&) {
```

If the code compiles, this is safe to land.

Reviewed By: dmm-fb

Differential Revision: D52957687
  • Loading branch information
r-barnes authored and facebook-github-bot committed Jan 24, 2024
1 parent 3db3934 commit c2a7c60
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fbpcs/data_processing/id_combiner/IdSwapMultiKey.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ void aggregateLiftNonIdColumns(
try {
int32_t val = std::stoi(dRow[col]);
columnValues[col].push_back(val);
} catch (std::exception& err) {
} catch (std::exception&) {
XLOG(FATAL)
<< "Error: Exception caught during casting string to int.\n"
<< "\tFor PL, non-id columns has to be int to aggregate in case of duplicates.";
Expand Down

0 comments on commit c2a7c60

Please sign in to comment.