Skip to content

Commit

Permalink
Remove unused exception parameter from fbpcs/data_processing/id_combi…
Browse files Browse the repository at this point in the history
…ner/DataValidation.cpp

Summary:
`-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it.

This:
```
try {
    ...
} catch (exception& e) {
    // no use of e
}
```
should instead be written as
```
} catch (exception&) {
```

If the code compiles, this is safe to land.

Reviewed By: yanglu-fb

Differential Revision: D52957709
  • Loading branch information
r-barnes authored and facebook-github-bot committed Jan 24, 2024
1 parent 3db3934 commit b1af1fc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fbpcs/data_processing/id_combiner/DataValidation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ void validateCsvData(std::istream& dataFile) {
for (auto& v : rowVec) {
try {
folly::to<std::uint64_t>(v);
} catch (std::exception& e) {
} catch (std::exception&) {
XLOG(FATAL) << v << " failed to parse to int";
}
}
Expand Down

0 comments on commit b1af1fc

Please sign in to comment.