Completo juego TicTacToe #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabsatz
reviewed
Mar 9, 2022
src/components/pages/TicTacToe.js
Outdated
| const gameEnded = false; | ||
| const [tiles,setTiles] = React.useState(['','','','','','','','','']); | ||
| const [currentPlayer,setCurrentPlayer]= React.useState(initialPlayer); | ||
| const [winner,setWinner] = React.useState(null); |
There was a problem hiding this comment.
en general, está bueno tratar de tener la menor cantidad de states posible. como el winner se puede sacar a partir del estado actual de los tiles, no es necesario que sea un state aparte. Si reemplazás esta línea por const winner = getWinner(tiles), debería andar igual y te ahorrás tener que setear el winner en setTileTo y restart
src/components/pages/TicTacToe.js
Outdated
Comment on lines
111
to
128
| <div className='tictactoe-row'> | ||
| <div className='square' value={tiles[0]} onClick={()=>{setTileTo(0, currentPlayer)}}>{tiles[0]}</div> | ||
| <div className='square' value={tiles[1]} onClick={()=>{setTileTo(1, currentPlayer)}}>{tiles[1]}</div> | ||
| <div className='square' value={tiles[2]} onClick={()=>{setTileTo(2, currentPlayer)}}>{tiles[2]}</div> | ||
| </div> | ||
| <div className='tictactoe-row'> | ||
| <div className='square' value={tiles[3]} onClick={()=>{setTileTo(3, currentPlayer)}}>{tiles[3]} | ||
| </div> | ||
| <div className='square' value={tiles[4]} onClick={()=>{setTileTo(4, currentPlayer)}}>{tiles[4]} | ||
| </div> | ||
| <div className='square' value={tiles[5]} onClick={()=>{setTileTo(5, currentPlayer)}}>{tiles[5]} | ||
| </div> | ||
| </div> | ||
| <div className='tictactoe-row'> | ||
| <div className='square' value={tiles[6]} onClick={()=>{setTileTo(6, currentPlayer)}}>{tiles[6]}</div> | ||
| <div className='square' value={tiles[7]} onClick={()=>{setTileTo(7, currentPlayer)}}>{tiles[7]}</div> | ||
| <div className='square' value={tiles[8]} onClick={()=>{setTileTo(8, currentPlayer)}}>{tiles[8]}</div> | ||
| </div> </div> |
There was a problem hiding this comment.
acá se repite bastante código, se te ocurre como hacerlo más simple? capaz con un par de .map()s?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.