Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #232 fixes #236

Merged
merged 10 commits into from
Oct 19, 2024
Merged

PR #232 fixes #236

merged 10 commits into from
Oct 19, 2024

Conversation

Xeckt
Copy link
Contributor

@Xeckt Xeckt commented Oct 18, 2024

This PR fixes the issues from #232

Fixes:

  • Remove AppConf passed directly to non-handler functions
  • Fix function parameters that use AppConfig directly, instead pass actual value references
  • Fix docs_path.push() inside git::new
  • Fix complexity inside app_conf load() function

Additions:

  • Add repo_path as an option for the possibility to relocate where the repo resides

@zleyyij zleyyij merged commit f530848 into r-Techsupport:main Oct 19, 2024
3 checks passed
@Xeckt Xeckt deleted the config-rewrite branch October 21, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants