Uri: Fix parsing login URI

qxmpp-project · Sep 10, 2024 · ad99be9 · ad99be9
1 parent 1935fde
commit ad99be9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/base/QXmppUri.cpp b/src/base/QXmppUri.cpp
@@ -293,7 +293,7 @@ Join parseJoinQuery(const QUrlQuery &q)
 Login parseLoginQuery(const QUrlQuery &q)
 {
  return {
- queryItemValue(q, u"login"_s),
+ queryItemValue(q, u"password"_s),
  };
 }
 

diff --git a/tests/qxmppuri/tst_qxmppuri.cpp b/tests/qxmppuri/tst_qxmppuri.cpp
@@ -81,6 +81,11 @@ void tst_QXmppUri::queryOther()
  QCOMPARE(unwrap<Uri::Join>(uri.query()), (Uri::Join { u"1234"_s }));
  QCOMPARE(uri.toString(), string);
 
+ string = u"xmpp:[email protected]?login;password=1234"_s;
+ uri = unwrap(QXmppUri::fromString(string));
+ QCOMPARE(unwrap<Uri::Login>(uri.query()), (Uri::Login { u"1234"_s }));
+ QCOMPARE(uri.toString(), string);
+
  string = u"xmpp:qxmpp.org?register"_s;
  uri = unwrap(QXmppUri::fromString(string));
  QCOMPARE(unwrap<Uri::Register>(uri.query()), (Uri::Register {}));