Skip to content

Commit

Permalink
fix: linter reference incorrect
Browse files Browse the repository at this point in the history
the linter for demo-app was incorrect pointing out to packages folder
indead of apps.

BREAKING CHANGE: N
  • Loading branch information
keuller committed Feb 24, 2023
1 parent 5ff1dbf commit 4a5d36f
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 13 deletions.
2 changes: 1 addition & 1 deletion apps/demo-app/.eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
"project": ["packages/demo-app/tsconfig.*?.json"],
"project": ["apps/demo-app/tsconfig.*?.json"],
"ecmaVersion": 2021,
"sourceType": "module",
"ecmaFeatures": {
Expand Down
18 changes: 9 additions & 9 deletions apps/demo-app/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "demo-app",
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"projectType": "application",
"sourceRoot": "packages/demo-app/src",
"sourceRoot": "apps/demo-app/src",
"targets": {
"build": {
"executor": "qwik-nx:build",
Expand All @@ -11,7 +11,7 @@
"demo-app:build.client",
"demo-app:build.ssr"
],
"outputPath": "dist/packages/demo-app"
"outputPath": "dist/apps/demo-app"
},
"configurations": {
"preview": {}
Expand All @@ -20,15 +20,15 @@
"build.client": {
"executor": "@nrwl/vite:build",
"options": {
"outputPath": "dist/packages/demo-app",
"configFile": "packages/demo-app/vite.config.ts"
"outputPath": "dist/apps/demo-app",
"configFile": "apps/demo-app/vite.config.ts"
}
},
"build.ssr": {
"executor": "@nrwl/vite:build",
"defaultConfiguration": "preview",
"options": {
"outputPath": "dist/packages/demo-app"
"outputPath": "dist/apps/demo-app"
},
"configurations": {
"preview": {
Expand All @@ -45,10 +45,10 @@
},
"test": {
"executor": "@nrwl/vite:test",
"outputs": ["../../coverage/packages/demo-app"],
"outputs": ["../../coverage/apps/demo-app"],
"options": {
"passWithNoTests": true,
"reportsDirectory": "../../coverage/packages/demo-app"
"reportsDirectory": "../../coverage/apps/demo-app"
}
},
"serve": {
Expand All @@ -62,14 +62,14 @@
"executor": "nx:run-commands",
"options": {
"command": "node --inspect-brk ../../node_modules/vite/bin/vite.js --mode ssr --force",
"cwd": "packages/demo-app"
"cwd": "apps/demo-app"
}
},
"lint": {
"executor": "@nrwl/linter:eslint",
"outputs": ["{options.outputFile}"],
"options": {
"lintFilePatterns": ["packages/demo-app/**/*.{ts,tsx,js,jsx}"]
"lintFilePatterns": ["apps/demo-app/**/*.{ts,tsx,js,jsx}"]
}
}
},
Expand Down
4 changes: 2 additions & 2 deletions apps/demo-app/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ export default defineConfig({
qwikCity(),
qwikVite({
client: {
outDir: '../../dist/packages/demo-app/client',
outDir: '../../dist/apps/demo-app/client',
},
ssr: {
outDir: '../../dist/packages/demo-app/server',
outDir: '../../dist/apps/demo-app/server',
},
}),
tsconfigPaths({ root: '../../' }),
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"version": "0.0.1",
"license": "MIT",
"scripts": {
"lint": "nx affected:lint --base=last-release",
"commit": "pnpx git-cz --disable-emoji",
"test": "nx test qwik-flow"
},
Expand Down

0 comments on commit 4a5d36f

Please sign in to comment.