Src layout #133
Merged
Src layout #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cneud
approved these changes
Aug 29, 2024
cneud
requested review from
vahidrezanezhad and
michalbubula
and removed request for
vahidrezanezhad and
michalbubula
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
quratornamespace #112Switch to
src-layout, i.e. all python sources are insrc, in theeynollahpackage.For users of the command line tool, there is no change.
When using eynollah in python scripts, one just has to remove the
qurator.prefix:(BTW we could do
from .eynollah import Eynollahin__init__.py, then you could dofrom eynollah import Eynollahwhich is less typing).This includes #131, so merging this PR will also merge the other.
I'd recommend merging this to main soon and then to merge main into the active development branches, because there will be some conflicts and the sooner we change this, the less the branches will diverge.