Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for pptpsetup without specifing --password parameter #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

franzo15
Copy link

@franzo15 franzo15 commented Apr 3, 2020

Use also perl module Term::ReadKey in order to prevent display the password in clear text

Use also perl module Term::ReadKey in order to prevent display the password in clear text
@quozl
Copy link
Owner

quozl commented Apr 5, 2020

Thanks. Reviewed.

  • removal of trailing whitespace has been lost, f449742,
  • accept passwords with quotes has been lost, e62bfa7,
  • indentation style has changed, inconsistent within file,
  • version changed but no explanation in commit message; it hasn't changed since 2006, does this mean you taking on responsibility to maintain this? I've been thinking of removing pptpsetup for the next release, now that Network Manager deals with configuration on desktop systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants