Simplified ConvertToArabic algorithm #733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that your version of the conversion of roman numbers back to arabic numbers is too complicated, and distracts a bit from the main focus, the following property testing topic.
I've taken the
ConvertToRoman(int)
algorithm using it backwards, basically. I've updated the markdown accordingly and let my wife audit the text as her english is better than mine. But I deleted a lot of your previous tests and text of the complicated algorithm you implemented. I hope you don't mind. There might now be a gap between the test forConvertToArabic("IV")
and the final version, but I don't know how to fill it. Maybe it's not even a problem, cause there were many test steps ahead of it already.