Conform to HTTP Style Guide #4977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeBishop
force-pushed
the
http/style_guide
branch
from
0afcd48
to
b395030
Compare
LPardue
approved these changes
Mar 31, 2022
MikeBishop
force-pushed
the
http/style_guide
branch
from
b395030
to
81e2b79
Compare
|
Note that while the style guide says to use 6265bis for COOKIES, I'm continuing to point to RFC 6265 unless and until we decide to take another delaying dependency. (I note that http-core also uses RFC 6265.) |
|
That sounds very sensible to me, especially given the context in which they are spoken to in this document. |
mnot
reviewed
Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4951 and some other things besides. This presupposes a resolution of httpwg/admin#41 to be "treat them the same as regular fields," which is ugly but logically consistent. Easy enough to adjust if that isn't the eventual decision, of course.