Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug uploading the debug artifact #2955

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Debug uploading the debug artifact #2955

merged 1 commit into from
Sep 6, 2023

Conversation

n8henrie
Copy link
Member

@n8henrie n8henrie commented Aug 28, 2023

This branch was to help debug CI for #2938 (comment)

@n8henrie
Copy link
Member Author

I think this is ready for merge. It uploads a debug executable along with the release artifacts, which should hopefully empower end users to help us debug issues.

@n8henrie
Copy link
Member Author

I've also updated the CI dependencies in this PR, which silences several annoying warnings.

@pjrobertson
Copy link
Member

I see Quicksilver-debug here :) https://github.com/quicksilver/Quicksilver/actions/runs/6007687787

Can it be given an extension in the name. Is it a .zip or .dmg?

@pjrobertson
Copy link
Member

@n8henrie - waiting on this change (Adding an extension) then I'll push a new release out :)

@n8henrie
Copy link
Member Author

n8henrie commented Sep 5, 2023

@pjrobertson -- I actually removed the .zip extension due to: https://github.com/actions/upload-artifact#zipped-artifact-downloads:

There is currently no way to download artifacts after a workflow run finishes in a format other than a zip or to download artifact contents individually. One of the consequences of this limitation is that if a zip is uploaded during a workflow run and then downloaded from the UI, there will be a double zip created.

So I had originally made it so that one saw foo.zip in the web interface, but once downloaded it showed as foo.zip.zip which I thought seemed uglier than having foo in the web interace and foo.zip once downloaded. I still think the latter is less ugly, but if you think it's more important to show the .zip in the web interface I'm happy to revert that.

@pjrobertson
Copy link
Member

Makes sense. I see that when I download it it is correctly named Quicksilver-debug.zip, so I think this change is fine.

Merging :)

@pjrobertson pjrobertson merged commit 5a77943 into main Sep 6, 2023
4 checks passed
@pjrobertson pjrobertson deleted the fix-debug-upload branch September 6, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants