fix(lex): parse let f = (): RT<T>=>null;
#1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegerot
force-pushed
the
pr1175
branch
3 times, most recently
from
1e8190c
to
e076dd5
Compare
strager
requested changes
Jan 10, 2024
| @@ -996,7 +996,12 @@ void Lexer::skip_less_less_as_less() { | |||
| void Lexer::skip_as_greater() { | |||
| switch (this->last_token_.type) { | |||
| case Token_Type::greater_equal: | |||
| this->last_token_.type = Token_Type::equal; | |||
| if (this->input_[0] == '>') { | |||
| this->last_token_.type = Token_Type::equal_greater; | |||
There was a problem hiding this comment.
Must fix: The => token's .end is incorrect after this change. The following example demonstrates the bug:
class C<T> {
f(): C<T>=> {
}
}There was a problem hiding this comment.
Fixed. What do you think?
vegerot
force-pushed
the
pr1175
branch
2 times, most recently
from
01a30d1
to
c2072c2
Compare
Test Plan: `let f = (): RT<T>=>null;` Fixes quick-lint#1169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(lex): parse
let f = (): RT<T>=>null;Test Plan:
let f = (): RT<T>=>null;Fixes #1169