remove N=1 check when decoding a literal field line with name reference #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field is only used to determine if the dynamic table can be used when this field is re-encoded. Since we currently don't support use of the dynamic table, the N value is irrelevant.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 5 5
Lines 233 233
=======================================
Hits 213 213
Misses 11 11
Partials 9 9 ☔ View full report in Codecov by Sentry. |
|
Changes look good. Tested and its working with the moq-rs. |
|
Thanks for testing and reporting back! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51.
This field is only used to determine if the dynamic table can be used when this field is re-encoded. Since we currently don't support use of the dynamic table, the N value is irrelevant.
@DineshAdhi @kixcord Could you take a quick look at this PR?