Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use regex to extract begin and end marker #298

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

soraxas
Copy link
Contributor

@soraxas soraxas commented Oct 26, 2024

fixes #68

See https://www.ietf.org/rfc/rfc4716.txt for SSH key format of BEGIN and END marker.

E.g., my id_rsa key is

-----BEGIN RSA PRIVATE KEY-----
..................
..................
..................
-----END RSA PRIVATE KEY-----

so we cannot hardcode the
-----BEGIN OPENSSH PRIVATE KEY-----
part

@quexten
Copy link
Owner

quexten commented Oct 26, 2024

Thank you for the PR!

-----BEGIN OPENSSH PRIVATE KEY-----

I assume your key is in the PKCS#8 format. Happy to merge but I'll have to do some testing. Just noting here that internally, 1Password uses pkcs#8, but modern ssh clients should only be generating openssh. The upcoming bitwarden implementation will also use openssh keys (but be able to import pkcs#8.

@quexten
Copy link
Owner

quexten commented Oct 30, 2024

Changes look good, will merge and just test before next release.

@quexten quexten merged commit 51940fa into quexten:main Oct 30, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH keys not working
2 participants