Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ExtendedAgent #123

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Implement ExtendedAgent #123

merged 1 commit into from
Feb 23, 2024

Conversation

csutcliff
Copy link
Contributor

Allows clients to specify the algorithm used via the SignWithFlags function. Currently this is rsa-sha2-256 or rsa-sha2-512 which are the two allowable options in the spec but it is extendable in the future as required.

Aiming to reduce code duplication, Existing Sign function retains it's default behaviour by calling SignWithFlags with SignatureFlagReserved.

The other ExtendedAgent function Extension returns ErrExtensionUnsupported to all calls as required by the spec.

Allows clients to specify the algorithm used via the `SignWithFlags` function. Currently this is `rsa-sha2-256` or `rsa-sha2-512` which are the two allowable options in the spec but it is extendable in the future as required.

Aiming to reduce code duplication, Existing `Sign` function retains it's default behaviour by calling `SignWithFlags` with `SignatureFlagReserved`.

The other `ExtendedAgent` function `Extension` returns `ErrExtensionUnsupported` to all calls as required by the spec.
@csutcliff
Copy link
Contributor Author

Please excuse the force pushes, it was my attempt at signing the commit (with goldwarden!). I think it was done correctly but I hadn't previously added my key to my github account and it appears it doesn't like it being added after the commit was signed hence it still showing Unverified.

@quexten
Copy link
Owner

quexten commented Feb 23, 2024

Thanks for the PR! The changes look good to me.

I think it was done correctly but I hadn't previously added my key to my github account and it appears it doesn't like it being added after the commit was signed hence it still showing Unverified.

I know GitLab only verifies when pushing the commits, but I had the impression that GitHub retroactively verifies too. Just to make sure, do you have the SSH key under both Authentication keys and Signing keys (or, alternatively, a separate key for each). It should show as something like: SHA256:veWACaljIB17oQ7FaMqSasP/Of/kp2i8Ni/KY8CSZ2g for you (going by the signed commit from the PR)

@csutcliff
Copy link
Contributor Author

Thanks, I had added it as authentication rather than signing.

@quexten quexten merged commit 23a336e into quexten:main Feb 23, 2024
10 checks passed
@quexten
Copy link
Owner

quexten commented Feb 23, 2024

Merged. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants