Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(view): dynamically update projection [OL5] #214

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

samuel-girard
Copy link

Hello,

This change brings the fact to dynamically update the projection of the map, as it is possible in OpenLayers example here: http://openlayers.org/en/latest/examples/reprojection-by-code.html
The change is to be applied only after #183 is merged.

I also added the example "view-projection-update" in the demo project to see it working.

@Neonox31
Copy link
Collaborator

@samuel-girard I fixed the linting problem on next branch, could you rebase please ?

@samuel-girard samuel-girard force-pushed the feat-view-projection-update branch from e1208ce to f30cab0 Compare December 17, 2018 09:52
@samuel-girard samuel-girard changed the title feat(view): dynamically update projection feat(view): dynamically update projection [OL5] Dec 17, 2018
@samuel-girard samuel-girard force-pushed the feat-view-projection-update branch from f30cab0 to 04c6ff2 Compare January 15, 2019 18:59
@Neonox31 Neonox31 force-pushed the next branch 2 times, most recently from 20086b9 to ee186a8 Compare February 4, 2019 10:43
@Yakoust Yakoust force-pushed the feat-view-projection-update branch from 04c6ff2 to b07b9d5 Compare April 9, 2019 12:14
@Yakoust
Copy link
Contributor

Yakoust commented Apr 9, 2019

I have an issue on demo, view does not reload when projection change.

_Chrome Version 73.0.3683.75 (Build officiel) (64 bits)

Ubuntu 18.04.2 LTS_

image

@samuel-girard
Copy link
Author

Hello @Yakoust

Yes, I can reproduce the problem. It looks like I forgot something here.
The following part is included in #213 and absolutely needed here:
https://github.com/quentin-ol/ngx-openlayers/blob/8d813c86782b10c3fb2276a6bb863c9693b5ad9f/projects/ngx-openlayers/src/lib/coordinate.component.ts#L46
It will make each coordinate reprojected on map projection change.
You should merge this only after #213

@Yakoust Yakoust force-pushed the feat-view-projection-update branch from b07b9d5 to eaf263d Compare April 10, 2019 08:54
@Yakoust Yakoust merged commit ae4b008 into quentinlampin:next Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants