-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add view and job table enhancements for improved observability #406
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Interesting idea. This does sound useful, but I'm not entirely sure the view needs to be in Que itself. I'll have a think, but I'm leaning towards adding it.
Could you squash the commits please?
@maxschridde1494 We love to look of that dashboard. Can it be released as a gem or similar? |
Linking bit about "first run at" extra data: #383 (comment) |
* Que migration v8: que_jobs_ext view; add first_run_at column to que_jobs
cd6ec2d
to
95b4ed6
Compare
@ZimbiX Thanks for the feedback. I went ahead and committed the change requests and squashed the commits. Re race conditions in the specs, I removed the sleep call in the run method and refactored the specs. I believe this removed the race conditions in most (if not all) the specs. For the two specs that test the locker info getting pulled in and the running status getting correctly set when lock ids are present, I referenced the locker_spec.rb and implemented the pattern used there. Please let me know if you have any feedback for this implementation. Thanks! |
Thanks for the positive feedback! We are currently working on packaging the new dashboard and will let you know as soon as it is available. |
@hlascelles We are happy to announce the release of create-groovestack.
|
Changes include:
Additional que_jobs.first_run_at column
The
first_run_at
column will store the timestamp with time zone (timestamptz) of the initial scheduled execution time for jobs. The column default is set to now, but realistically this will always default to the initialrun_at
value. This enhancement helps re-trace the execution of jobs when reviewing failures.NEW que_jobs_ext view
This view extends the functionality of the job management system by providing an enriched view of jobs. It combines data from the
que_jobs
table and thepg_locks
table to present a comprehensive overview of jobs, including their status and locking details. Here is an example SQL command highlighting usage of the new view:We have used these new enhancements to power some of our admin dashboards. Below is a video of one such example.