This repository has been archived by the owner on Apr 4, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Merging kafka-connect-hdfs 3.3.0 to support Kafka 0.11 #49
Open
lewisdawson
wants to merge
105
commits into
qubole:master
Choose a base branch
from
lewisdawson:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gainst-the-wrong-class'
Fix issue with topic names containing dots, not being compatible with hive (replace dot with underscore) After initial feedback/code review: Added test Removed unused imports accidentally added.
Issue 136 - Support topic with dots in hive.
* Update Readme * Update Readme
- Automatic commit via: tbr apply-feature-freeze -e prod --no-dry-run PLATFORM
- Automatic commit via: tbr apply-feature-freeze -e prod --no-dry-run PLATFORM
- Automatic commit via: tbr apply-feature-freeze -e prod --no-dry-run PLATFORM
* Handle primitive types in AvroRecordWriterProvider. * Use named variable in test instead of repeating constants.
Upgrade avro to 1.8.2
- Automatic commit via: tbr apply-rc-tag --rc 2 --confluent-patch 2 --build temp-rc-settings -e prod PLATFORM --skip-projects security,confluent-cli --no-dry-run
Add 3.3.0 changelog
- Automatic commit via: tbr apply-rc-tag --rc 4 --confluent-patch 1 --build release -e prod CAMUS PLATFORM --no-dry-run
Update quickstart to use Confluent CLI
Hi @lewisdawson thanks for your work on this. Will love to discuss how we can test this and get it merged. Are you open for a chat ? (My email is [email protected]) |
#!/usr/bin/env groovy | ||
common { | ||
slackChannel = '#connect-eng' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the Jenkinsfile needed?
@lewisdawson Any plans to upgrade this PR to 4.0? HDFS connect was refactored to use kafka-connect-storage-common |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the connector to work with Kafka 0.11. I also upgraded Guava to 20.0 to fix the
NoSuchMethodError
I was seeing under #48.