Add timeout option in connection wrapper (#119) #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just saw last commit is months ago... Do you think this can be merged in the shortterm and not in months @SandeepBelagavi, @chattarajoy, @akaranjkar-qu ? I highly appreciate a short response from anybody on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have faced the same issue that was mentioned in #119 .
The default
300seconds as timeout for connections to QDS was not big enough to run commands for heavy load SQL queries against QDS.This PR enables users to specify their custom
timeoutvalue as a parameter and removes the hardcoded default value from the SDK. It furthermore helps overcome theHTTPSConnectionPool(host='qubole.com', port=443): Read timed out. (read timeout=300)error raised byrequests.exceptions.Timeoutwhen commands do not finish before the default300s.