Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get-template-library: Quattor version update in cluster build properties #366

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

jouvin
Copy link
Contributor

@jouvin jouvin commented Nov 9, 2024

Intended to help producing a useful configuration without the need to update the template-libary-examples repository at each Quattor version.

No impact on current use in CI tests as what is implemented in this PR was already done when request Quattor version was HEAD, like in the CI tests.

@jouvin jouvin requested a review from jrha November 9, 2024 11:41
@jouvin jouvin added this to the 24.10 milestone Nov 9, 2024
@jouvin
Copy link
Contributor Author

jouvin commented Nov 9, 2024

I'll fix codeclimate errors later during the week-end...

…Quattor version

- Done only for HEAD previously
- Option --no-build-properties-update added to disable it (even for HEAD)
@jouvin jouvin force-pushed the cluster_build_properties_update branch 10 times, most recently from 318f44e to 67e4b86 Compare November 10, 2024 17:02
@jouvin
Copy link
Contributor Author

jouvin commented Nov 10, 2024

It took more time than anticipated but I managed to make codeclimate happy :-) and learned a lot of things :-)

…imate

- Replace -a by &&
- egrep replaced by grep -E
- grep usage to check a variable content
- variable quoting
- variable definition testing
@jouvin jouvin force-pushed the cluster_build_properties_update branch from 67e4b86 to 4b9d56c Compare November 12, 2024 11:26
@jrha jrha merged commit 22ca60e into quattor:master Nov 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants