Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncm-metaconfig: zookeeper: Fix wrapping and indentation in pan #1800

Merged
merged 1 commit into from
Dec 16, 2024
Merged

ncm-metaconfig: zookeeper: Fix wrapping and indentation in pan #1800

merged 1 commit into from
Dec 16, 2024
+5 −2

Conversation

jrha
Copy link
Member

@jrha jrha commented Dec 12, 2024

No description provided.

@jrha jrha added the cleanup label Dec 12, 2024
@jrha jrha added this to the 25.next milestone Dec 12, 2024
ned21
ned21 reviewed Dec 15, 2024
View reviewed changes
Copy link
Contributor

@ned21 ned21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new formulation looks a bit weird? The [] at the end is really important and perhaps easy to overlook if it's on its own line?

@jrha
ncm-metaconfig: zookeeper: Fix wrapping and indentation in pan
c4e35d1 
Introduce new zookeeper_four_letter_word type for clarity.
@jrha jrha force-pushed the cleanup-metaconfig-zookeeper branch from 840f507 to c4e35d1 Compare December 16, 2024 11:44
@jrha
Copy link
Member Author

jrha commented Dec 16, 2024

Good point, thanks. I've made it a new type for clarity.

@jrha jrha merged commit d655111 into quattor:main Dec 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned21 ned21 ned21 approved these changes

Assignees
No one assigned
Labels
cleanup
Milestone
25.next
Development

Successfully merging this pull request may close these issues.
2 participants
@jrha @ned21