Add js0n.h header guards and include js0n.h from js0n.c. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Projects like pktriggercord and deriving from that, libgphoto2, are using js0n.[h,c] sources in their projects. Couple changes came up when doing cleanups on those projects. First change is to add header guard 'JS0N_H' to js0n.h. This is generally standard practice and wouldn't hurt. Secondly there is now an '#include "js0n.h"' statement in js0n.c. This is to quiet some compiler warnings about js0n(...) not being previously declared. While it shouldn't be necessary in theory it shouldn't hurt either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projects like pktriggercord and deriving from that, libgphoto2, are using js0n.[h,c] sources in their projects. Couple changes came up when doing cleanups on those projects.
First change is to add header guard 'JS0N_H' to js0n.h. This is generally standard practice and wouldn't hurt.
Secondly there is now an '#include "js0n.h"' statement in js0n.c. This is to quiet some compiler warnings about js0n(...) not being previously declared. While it shouldn't be necessary in theory, it shouldn't hurt either.