Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarto_bin_sitrep() addition to get situation with RStudio IDE configuration #145

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Jan 26, 2024

Closes #12

@jthomasmock can you have a look ? What do you think ?

Doing this, I am also feeling this would be good for this package to try use the bundle Quarto version when used inside RStudio... 🤔

@jthomasmock
Copy link

Doing this, I am also feeling this would be good for this package to try use the bundle Quarto version when used inside RStudio...

Yes - this was the discussion I had with @dragonstyle - we should consolidate the ways that R and RStudio handle Quarto path.

Maybe that means only: QUARTO_PATH - respected by RStudio and R and $PATH for shell since it won't recognize R env variables typically.

@cderv
Copy link
Collaborator Author

cderv commented Jan 26, 2024

Maybe that means only: QUARTO_PATH - respected by RStudio and R and $PATH for shell since it won't recognize R env variables typically.

If this is what you think is best, then there is no change to do in the package, and this would be an IDE feature request.

@jthomasmock
Copy link

Based off the tests, this looks right - thanks @cderv !

@jthomasmock
Copy link

My only feedback would be maybe rename to quarto_binary_sitrep() it's a "handful" but bin makes me think of /bin directory on linux and the 3 extra letters ary help with clarifying.

@cderv
Copy link
Collaborator Author

cderv commented Jan 29, 2024

I am fine with that ! Thanks. Getting feedback about better user's experience is quite helpful - thanks !

@cderv cderv merged commit f986fb6 into main Jan 29, 2024
@cderv cderv deleted the quarto-bin-sitrep branch January 29, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request - Return Quarto version
2 participants