Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Use jog to as the traversal method in filters #11540

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

[WIP] Use jog to as the traversal method in filters #11540

wants to merge 32 commits into from

Conversation

tarleb
Copy link
Collaborator

@tarleb tarleb commented Nov 26, 2024

Use jog instead of walk.

@tarleb
Use the built-in error function to trigger a fatal error
fa6750b
@tarleb
Provide global function quarto_assert
52b83d9 
This behaves mostly like the built-in `assert`, but respects the general
Quarto scaffolding.
@tarleb
Add Lua utils function quarto.utils.is_empty_node
17b1dd1
@tarleb
Use Inlines metatable for "list of Inline" return values
c7e4597
@tarleb
Rewrite as_inlines, as_blocks with focus on performance
4274ec0 
This also fixes unwanted behavior of `as_blocks`, which would treat a
list of Inline elements as a list of singleton Plain elements, leading
to bad results.
@tarleb
Rewrite as_inlines, as_blocks with focus on performance
5ade0e2 
This also fixes unwanted behavior of `as_blocks`, which would treat a
list of Inline elements as a list of singleton Plain elements, leading
to bad results.
@tarleb
Prevent unintended side-effects of filter functions
2967ace
@tarleb
table-rawhtml: destructively modify the input list
3ac2284 
Minor performance improvement.
@tarleb
lightbox: Restart imgCount each time the filter is invoked.
00f20e0 
This allows to get reproducible output when running the filter multiple
times.
@tarleb
Return modified meta object from init filter
4f93ae2 
If the metadata object is modified in a filter, then it should be
returned, as otherwise the changes might be lost.
@tarleb
Fix check for empty captions in parsefiguredivs filters
e5111ca 
The `long` field of a caption can never be nil, but it can be an empty
list.
@tarleb
Use proper metadata types when resolving dependencies
ed2747b
@tarleb
Ensure that the internal Meta copy is a true, deep copy
5101add
@tarleb
Don't add number values to the metadata object
b9b051c
@tarleb
Custom nodes: cleanup code for slots/forwarder
13636f9
@tarleb
Fix type of return value in typst filter function
594b00a
@tarleb
Fix type in Caption
adc49e9
@tarleb
Ensure proper Callout rendering if title is set but empty
f624315
@tarleb
Rely less on pandoc's type implicit conversions
fa9af92
@tarleb
Ensure proper types when setting custom node slots
7d56b40
@tarleb
Use global function to check if caption if empty
ae4056e
@tarleb
Avoid type confusion with captions during crossref handling
6fe2889
@tarleb
Ensure Blocks when normalizing draft posts
d8cbd96
@tarleb tarleb mentioned this pull request Nov 26, 2024
Closed
3 tasks
@tarleb tarleb force-pushed the jog-as-default branch 2 times, most recently from 465b7b4 to 7879268 Compare November 26, 2024 21:28
@tarleb
Add jog Lua module
c78717f
@tarleb
Allow to use jog instead of walk
39e1638 
Jog can be enable on a per-filter basis by setting the `traverse` field
to `jog`.
@tarleb
Use jog for traversals in most normalization filters
e532045 
The exception is `normalize-combine-2`, which causes test failures when
using `jog`.
@tarleb
Use jog for traversals in post filters
57f5ef7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tarleb