fix writeTextFileSyncPreserveMode() to correctly keep mode from a known file #11534
+49
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This API is a little weird. Can we talk about it? |
|
yes definitely; Feel free to suggest a different one too. I hesitated about the order of the arguments but maybe you have even something completely different in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11532 regression from 1.6 due to #10657 which reverted back to #660
writeTextFileSyncPreserveMode()now correctly takes two argumentsThe path could be the same. And this is what it was supposed to be from refactoring in #10657.