Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few changes for Deno 2 runtime compatibility #11351

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tjni
Copy link

@tjni tjni commented Nov 9, 2024

Description

This PR moves a few method calls that were deprecated and removed in Deno 2 to their replacements (except for Deno.metrics(), which was removed without replacement).

This is not a complete set of changes: some dependencies also need to be updated or patched (xmlp is the main one that I'm aware of right now), but testing the waters here with this smaller and simpler one since this is my first contribution.

Checklist

I have (if applicable):

  • filed a contributor agreement.
  • referenced the GitHub issue this PR closes
  • updated the appropriate changelog in the PR
  • ensured the present test suite passes
  • added new tests
  • created a separate documentation PR in Quarto's website repo and linked it to this PR

@tjni
Copy link
Author

tjni commented Nov 9, 2024

Regarding the contributor agreement form, what goes in the "fascimile" field?

@cscheid
Copy link
Collaborator

cscheid commented Nov 15, 2024

Regarding the contributor agreement form, what goes in the "fascimile" field?

A fax number if your company has one - no entry otherwise.

@cscheid cscheid added this to the v1.7 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants