Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create project can now open in Positron #10615

Merged
merged 2 commits into from
Aug 27, 2024
Merged

create project can now open in Positron #10615

merged 2 commits into from
Aug 27, 2024

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Aug 27, 2024

This PR teaches Quarto about Positron as an editor for quarto create project

  • Either to select using quarto create project --open positron
  • Either to detect when command is ran into Positron directly

Help page shows the new support

❯ quarto create --help

Usage:   quarto create [type] [commands...]
Version: 99.9.9

Description:

  Create a Quarto project or extension

Options:

  -h, --help              - Show this help.
  --open        [editor]  - Open new artifact in this editor (positron, vscode, rstudio)
  --no-open               - Do not open in an editor

(...)

I checked the Windows paths for default installation of both installers.

This solves #10268

src/command/create/editor.ts Outdated Show resolved Hide resolved
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added isPositronTerminal() and isPositron() to match with other editor, as the env var is POSITRON and not terminal specific it seems. TERM_PROGRAM is vscode like for VSCODE so not helpful.

I asked confirmation for the env var to check to Positron team.

@cderv
Copy link
Collaborator Author

cderv commented Aug 27, 2024

Working on Windows (tested by me) and Mac (tested by @gordonwoodhull)

@cderv cderv merged commit bb29023 into main Aug 27, 2024
47 checks passed
@cderv cderv deleted the project/open-positron branch August 27, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running quarto create project blog . in Positron Terminal opens VSCode window
2 participants