-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect max message size property fo Quarkus GRPC client (44853) #44855
Conversation
5065e14
to
ddeb9c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This comment has been minimized.
This comment has been minimized.
Can you check the formatting? |
Sure. The imports are sorted now. |
This comment has been minimized.
This comment has been minimized.
Can you squash your commits? |
d6f5f42
to
85f0344
Compare
Done |
@cescoffier should this be backported? |
Sorry, I have synchronized it with the main branch wrong. Should I reopen with clean branch and commits? |
You can just rebase your branch onto |
4e98b1c
to
b26c421
Compare
Great, thanks. Never used force push before :) |
It's perfectly fine to do that on your own branches (that are not being worked by others) |
Status for workflow
|
🎊 PR Preview c10465e has been successfully built and deployed to https://quarkus-pr-main-44855-preview.surge.sh/version/main/guides/
|
Status for workflow
|
If it backports cleanly yes. |
I tried to backport it to 3.17 and I have the following test failure: The issue can be seen in this (now probably hidden) issue: #44897 (comment) . @cescoffier any clue? |
Uh, no idea, since this change looks trivial / simple. |
Fixes #44853 and gives a workaround for #44852