Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect max message size property fo Quarkus GRPC client (44853) #44855

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

alex-pumpkin
Copy link
Contributor

Fixes #44853 and gives a workaround for #44852

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This comment has been minimized.

@cescoffier
Copy link
Member

Can you check the formatting?

@alex-pumpkin
Copy link
Contributor Author

Sure. The imports are sorted now.

This comment has been minimized.

@cescoffier
Copy link
Member

Can you squash your commits?

@alex-pumpkin
Copy link
Contributor Author

Done

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 2, 2024
@geoand
Copy link
Contributor

geoand commented Dec 2, 2024

@cescoffier should this be backported?

@alex-pumpkin
Copy link
Contributor Author

Sorry, I have synchronized it with the main branch wrong. Should I reopen with clean branch and commits?

@geoand
Copy link
Contributor

geoand commented Dec 2, 2024

You can just rebase your branch onto main and then force push

@alex-pumpkin
Copy link
Contributor Author

Great, thanks. Never used force push before :)

@geoand
Copy link
Contributor

geoand commented Dec 2, 2024

It's perfectly fine to do that on your own branches (that are not being worked by others)

Copy link

quarkus-bot bot commented Dec 2, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 48dc90c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

github-actions bot commented Dec 2, 2024

🎊 PR Preview c10465e has been successfully built and deployed to https://quarkus-pr-main-44855-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link

quarkus-bot bot commented Dec 2, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b26c421.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@cescoffier
Copy link
Member

If it backports cleanly yes.

@geoand geoand merged commit d1104d5 into quarkusio:main Dec 2, 2024
36 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 2, 2024
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Dec 2, 2024
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.3 Dec 3, 2024
@gsmet
Copy link
Member

gsmet commented Dec 3, 2024

I tried to backport it to 3.17 and I have the following test failure:

Screenshot from 2024-12-03 18-30-27

The issue can be seen in this (now probably hidden) issue: #44897 (comment) .

@cescoffier any clue?

@gsmet gsmet modified the milestones: 3.17.3, 3.18 - main Dec 3, 2024
@cescoffier
Copy link
Member

@gsmet Nope, I don't why this PR could change this test. (@alesj any idea).

BTW, due to the last comment on #44852, I don't believe we should backport. We need to understand the behavior difference between gRPC java and the Vert.x gRPC first. (removing the label, sorry about that).

@alesj
Copy link
Contributor

alesj commented Dec 4, 2024

(@alesj any idea).

Uh, no idea, since this change looks trivial / simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus Vertx GRPC Client should respect "max-inbound-message-size" property
5 participants