Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make quarkus.docker.buildx.platform default to local #44015

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make quarkus.docker.buildx.platform default to local #44015

wants to merge 1 commit into from
+2 −0

Conversation

xstefank
Copy link
Member

Fixes #44012

@xstefank xstefank requested a review from iocanel October 22, 2024 09:30
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 22, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 090b567.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

@github-actions GitHub Actions
Copy link

🎊 PR Preview e9293aa has been successfully built and deployed to https://quarkus-pr-main-44015-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 22, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 090b567.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

gsmet
gsmet reviewed Oct 22, 2024
View reviewed changes
...cker/deployment/src/main/java/io/quarkus/container/image/docker/deployment/DockerConfig.java
@@ -32,6 +33,7 @@ interface DockerBuildxConfig {
* Which platform(s) to target during the build. See
* https://docs.docker.com/engine/reference/commandline/buildx_build/#platform
*/
@WithDefault("local")
Optional<List<String>> platform();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, please remove the Optional given we don't need it anymore. I would expect us to always want it set to something, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure if this is a good solution, but if @iocanel or @maxandersen confirm, I will remove optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@iocanel iocanel Awaiting requested review from iocanel

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quarkus image build with Podman doesn't push resulting image into local registry
2 participants
@xstefank @gsmet