Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 42549 - replaces oidc auth github screenshots with more generic ones #44004

Conversation

rghara
Copy link

@rghara rghara commented Oct 21, 2024

Fix replaces oidc auth github screenshots with more generic ones

@sberyozkin
Copy link
Member

Thanks @rghara , LGTM, I'd like to ask you to do a few minor updates, please name the application as Quarkus Github, it is actually an Oauth2 aware application, but it wiul still be a bit technical.
And if you don't mind have a callback URL like http://localhost:8080/github, since userinfo can cause some confusion due to the association with UserInfo

Copy link

github-actions bot commented Oct 21, 2024

🙈 The PR is closed and the preview is expired.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 22, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit ca8cbca.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin
Copy link
Member

Hi @rghara It is ready to go now but the rebasing did not work out, I guess it is simplest at this stage to close this PR and open a new one, and I'll merge. Would you like to go ahead and replace this PR ? Note it does not fix the linked issue as a few other Renarde references remain in some other application setups there, but fixing Github instructions is important

@rghara rghara closed this Oct 22, 2024
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Oct 22, 2024
@rghara
Copy link
Author

rghara commented Oct 22, 2024

Hi @rghara It is ready to go now but the rebasing did not work out, I guess it is simplest at this stage to close this PR and open a new one, and I'll merge. Would you like to go ahead and replace this PR ? Note it does not fix the linked issue as a few other Renarde references remain in some other application setups there, but fixing Github instructions is important

@sberyozkin
I think I need to create a new branch all together. I will gradually replace the others as well. It takes too much time to replace all of them at once. Started creating for Google as the next change.

@rghara
Copy link
Author

rghara commented Oct 22, 2024

@sberyozkin
Created a new pull request. It seems it is passing the checks.
#44023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants