MultiStage Docker instructions needed chmod ./mvnw
#43978
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
gsmet
reviewed
Oct 21, 2024
| @@ -584,6 +584,7 @@ COPY --chown=quarkus:quarkus .mvn /code/.mvn | |||
| COPY --chown=quarkus:quarkus pom.xml /code/ | |||
| USER quarkus | |||
| WORKDIR /code | |||
| RUN chmod +x ./mvnw | |||
There was a problem hiding this comment.
Not very familiar with the Docker format but can't we copy and keep the permissions above?
There was a problem hiding this comment.
Good question. I am also not an expert! let me find out
There was a problem hiding this comment.
Combined them into one command
melloware
changed the title
RUN chmod +x ./mvnwchmod ./mvnw
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used these instructions to deploy to Koyeb and it would fail saying
/bin.shcould not runmvnwso I had to addAnd then it worked. You can see my Koyeb deploy script here: https://github.com/melloware/quarkus-faces/blob/main/Dockerfile.koyeb