Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude uri from otel tracing #43885

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Oct 15, 2024

What

This pull request creates a new BuildItem that is used for drop uri from tracing when using quarkus-opentelemetry extension. The DropApplicationUrisBuildItem is generated from the scanning of the @Traceless annotation.

The @Traceless annotation is used with the jakarta.ws.rs.Path annotation. If annotated at class level all uri below will be ignored for tracing.

If your @Path annotation contains expression like @Path("/cars/{carId}") the extension will ignore all thing after cars using, e.g. cars*.

Why

You can see the issue below, or directly this Stackoverflow discussion.

Fixes #42659

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 15, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 15, 2024

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

@mcruzdev
Copy link
Contributor Author

mcruzdev commented Oct 15, 2024

First draft pull request. Feel free to add any suggestions!

cc: @brunobat

@mcruzdev mcruzdev marked this pull request as ready for review October 20, 2024 02:21
Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is moving in the right direction @mcruzdev.
I think you should add a property where you could add a list of strings with paths that can be ignored.
it you could add a test in quarkus-integration-test-opentelemetry it would be great.

@quarkus-bot

This comment has been minimized.

Copy link

🎊 PR Preview 1b11ce1 has been successfully built and deployed to https://quarkus-pr-main-43885-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add exclude paths to OpenTelemetry Tracing
2 participants