Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Artemis JMS documentation #4186

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Add Artemis JMS documentation #4186

merged 2 commits into from
Sep 25, 2019

Conversation

middagj
Copy link
Contributor

@middagj middagj commented Sep 24, 2019

As requested in #2930 an Artemis guide. I tried to copy AMQP's example, but couldn't got the Server-sent-events working in this short time so I used a simple fetch button.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I added a few suggestions.

docs/src/main/asciidoc/artemis-jms-guide.adoc Show resolved Hide resolved
docs/src/main/asciidoc/artemis-jms-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/artemis-jms-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/artemis-jms-guide.adoc Outdated Show resolved Hide resolved
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 25, 2019
@gsmet
Copy link
Member

gsmet commented Sep 25, 2019

Looks good to me, now, thanks! Let's wait for CI. I let you prepare the quickstart and create a PR for it?

@middagj
Copy link
Contributor Author

middagj commented Sep 25, 2019

Thanks I took over your suggestion. I used several other guides as example, so you might want to change the mvn into ./mvnw there as well.

@geoand geoand merged commit 4896533 into quarkusio:master Sep 25, 2019
@middagj
Copy link
Contributor Author

middagj commented Sep 25, 2019

@gsmet, I already created a quickstart, see #quarkusio/quarkus-quickstarts#291

@middagj middagj deleted the feature/artemis-doc branch September 25, 2019 18:43
@gsmet
Copy link
Member

gsmet commented Sep 25, 2019

OK, perfect, thanks! I'll have a look soon.

@gsmet gsmet added this to the 0.24.0 milestone Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/noteworthy-feature triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants