Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove devconsole-spi from core #35426

Merged

Conversation

phillip-kruger
Copy link
Member

@gsmet the classes in the spi module is already deprecated. This PR remove all usage from core.

@phillip-kruger
Copy link
Member Author

Seems like we still need to ignore the test. I assume it used to pull in the dev-console-spi as transitive dependency. Or I can add those to the quickstart

@quarkus-bot

This comment has been minimized.

@phillip-kruger
Copy link
Member Author

Waiting on quarkusio/quarkus-quickstarts#1320

Signed-off-by: Phillip Kruger <[email protected]>
@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 22, 2023
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 23, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@phillip-kruger phillip-kruger merged commit 8d51c06 into quarkusio:main Aug 23, 2023
47 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 23, 2023
@phillip-kruger phillip-kruger deleted the deprecate-devconsole-spi branch August 23, 2023 00:56
@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 23, 2023
@famod
Copy link
Member

famod commented Sep 7, 2023

@phillip-kruger I might be missing something, but should be something added to the migration guide?
Thing is: I tried Quarkus 3.4.0.CR1 and I got ClassNotFoundException: io.quarkus.devconsole.spi.DevConsoleTemplateInfoBuildItem.
Turns out quarkus-cxf needs to add quarkus-vertx-http-dev-console-spi to fix this.

@gsmet
Copy link
Member

gsmet commented Sep 7, 2023

@famod we will reintroduce the dependency in 3.4. We didn't think it would break so many extensions. @phillip-kruger will create a PR soon.

@famod
Copy link
Member

famod commented Sep 7, 2023

@gsmet ah, good to know. Is this just a short-term remedy? Meaning: Does it make sense to add it explicitly in quarkus-cxf regardless?

@gsmet
Copy link
Member

gsmet commented Sep 7, 2023

No, it doesn't make sense: Quarkus CXF should get rid of using these classes as it's the old Dev Console and it's gone.

It's not the only extension affected.
The plan is to drop this in 3.5 and communicate in advance so that extensions can adapt to this change.

So we want this change to be done but we didn't communicate well enough about it, that's why we are reverting it temporarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants