Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to nonexistent v1 dev UI from quickstart #1457

Closed
wants to merge 1 commit into from

Conversation

holly-cummins
Copy link
Contributor

While I was looking at the index html, I noticed it's out of date in a few other ways (references to reactive, etc) so I've tidied those up as well.

@holly-cummins holly-cummins changed the base branch from main to development September 26, 2024 20:19
@holly-cummins holly-cummins changed the base branch from development to main September 26, 2024 20:20
@holly-cummins holly-cummins changed the base branch from main to development September 26, 2024 20:21
While I was looking at the index html, I noticed it's out of date in a few other ways (references to reactive, etc) so I've tidied those up as well.
@quarkus-bot

This comment has been minimized.

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is using a later version of Quarkus, you can just remove the index file, as it's dynamic now

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 26, 2024

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 76fbbe0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@holly-cummins
Copy link
Contributor Author

If this is using a later version of Quarkus, you can just remove the index file, as it's dynamic now

I realised we do it dynamically after I'd made the changes, but didn't think about the implications for this quickstart. I guess in the development branch it definitely will be a later version of Quarkus, and the less code we have the better, so good idea, I'll remove it. Thanks.

@holly-cummins
Copy link
Contributor Author

Actually, should we remove the index.htmls for all quickstarts in this repository?

@phillip-kruger
Copy link
Member

Yes I think we can remove it from all quickstarts (if they use the latest Quarkus)

@holly-cummins
Copy link
Contributor Author

Closing in favour of #1459.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants