Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download file method should have byte[] as response content #1400

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

petro1
Copy link
Contributor

@petro1 petro1 commented Mar 21, 2024

fix: download file method should have byte[] as response content

@petro1 petro1 changed the title Patch-1 fix: download file method should have byte[] as response content Mar 21, 2024
@scrocquesel
Copy link
Contributor

@gsmet LGTM

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 25, 2024

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit afbe5e1.

Failing Jobs

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Build - JDK 17 #

- Failing: hibernate-orm-multi-tenancy-quickstart quartz-quickstart security-openid-connect-multi-tenancy-quickstart 

📦 hibernate-orm-multi-tenancy-quickstart

org.acme.hibernate.orm.FruitsEndpointTest.testListAllFruitsBaseSchema - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:643)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:727)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

📦 quartz-quickstart

org.acme.quartz.TaskResourceTest.tasks - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:643)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:727)
	at java.base/java.util.Optional.orElseGet(Optional.java:364)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)

📦 security-openid-connect-multi-tenancy-quickstart

org.acme.quickstart.oidc.CodeFlowTest.testReAuthenticateWhenSwitchingTenants line 89 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <Sign in to quarkus> but was: <>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
	at org.acme.quickstart.oidc.CodeFlowTest.testReAuthenticateWhenSwitchingTenants(CodeFlowTest.java:89)

@petro1
Copy link
Contributor Author

petro1 commented Mar 26, 2024

I see the jdk build failed, what can we do here? Thanks.

@gsmet gsmet merged commit ededd15 into quarkusio:development Mar 26, 2024
2 of 3 checks passed
@gsmet
Copy link
Member

gsmet commented Mar 26, 2024

It's unrelated. We have some issues because CI tries to build with Quarkus main and these quickstarts are still based on 3.9.
Thanks for the PR!

@petro1 petro1 deleted the patch-1 branch March 27, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants