Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1304 #1305

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Fixes #1304 #1305

wants to merge 1 commit into from

Conversation

llowinge
Copy link

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

@llowinge
Copy link
Author

@gsmet Could you please review ? Thank you.

@gsmet
Copy link
Member

gsmet commented Jul 28, 2023

Hey @llowinge ,

I see we have two PRs fixing the same issue: #1309 .

I'm not sure what is best.

@cescoffier do you have a preference?

@mocenas mocenas mentioned this pull request Aug 7, 2023
Open
10 tasks
@llowinge
Copy link
Author

Hi @gsmet @cescoffier any updates on this ? Thank you in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llowinge @gsmet