-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support gRPC TLS communication and TLS registry and FW support for gRPC on same server #1272
Support gRPC TLS communication and TLS registry and FW support for gRPC on same server #1272
Conversation
8235fb4
to
6fb8fd3
Compare
6fb8fd3
to
8ed7b70
Compare
Issues on Windows are related to escaping, I don't know if I fixed them as obviously I didn't try it (it's bit late...). If it's red tomorrow, I'll work around that, but it's a small thing, I think you can freely comment on changes. Thanks |
Interesting, Quarkus turns
I'll play with it tomorrow. |
Starting experiments on Windows, will report back when I fix it. |
4d37c90
to
3c9f345
Compare
I have doubled backslashes for my use case, which fixed the issue. I think we need to do it for everywhere #1275 but I do not there to do this in here. I am in hurry and don't have time to fix/debug side-effects in backports etc. |
3c9f345
to
e835cc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a couple of small changes.
And what about Openshift? Will it work there?
quarkus-test-service-grpc/src/main/java/io/quarkus/test/bootstrap/GrpcService.java
Outdated
Show resolved
Hide resolved
quarkus-test-service-grpc/src/main/java/io/quarkus/test/bootstrap/GrpcService.java
Outdated
Show resolved
Hide resolved
examples/grpc/src/test/java/io/quarkus/qe/grpc/GrpcMtlsTlsRegistryIT.java
Show resolved
Hide resolved
#1053 IIRC you cannot have both enabled HTTP2 and HTTP1 in OpenShift cluster. Things might have changed, but it's beyond what I can do ATM. |
Following jobs contain at least one flaky test: 'Linux - JVM build - Released Versions' |
e835cc1
to
7555535
Compare
Summary
AfterEach
andBeforeEach
like here: https://github.com/quarkusio/quarkus/blob/main/integration-tests/grpc-mutual-auth/src/test/java/io/quarkus/grpc/examples/hello/HelloWorldMutualTlsServiceTest.javahttp/grpc
module, I prepared changes in TS here quarkus-qe/quarkus-test-suite@14fdffb (that commit also adapts TS to other breaking changes I introduced in my other PRs before this one) and tested it with them:XeparateServer
toSeparateServer
(I only run it few times, I don't swear on it...)SameServerIT
https://github.com/quarkus-qe/quarkus-test-suite/blob/main/http/grpc/src/test/java/io/quarkus/ts/http/grpc/SameServerIT.java had to work around FW support for same server, this fixes itPlease check the relevant options
run tests
phrase in comment)Checklist: