Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust code.quarkus site tests to the new layout with presets #409

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

rsvoboda
Copy link
Member

Adjust code.quarkus site tests to the new layout with presets, this fixes failures we have in daily CI - https://github.com/quarkus-qe/quarkus-startstop/actions/workflows/ci.yaml

  • https://code.quarkus.redhat.com was updated to have presets
  • new pageLoadedSelector was identified to work with old and new version
  • validatePresenceOfSupportedFlags now checks grpc extension URL because the default page has presets without a visible list of extensions

Example commands for execution (code-3-15-1 has old version deployed):

mvn clean verify -Ptestsuite-community-no-native -Dtest=CodeQuarkusSiteTest
mvn clean verify -Ptestsuite-community-no-native -Dtest=CodeQuarkusSiteTest -Dcode.quarkus.url=https://code-3-15-1-redhat-00003.apps.ocp-c1.prod.psi.redhat.com/

I will create backports for 3.8 and 3.15 once this gets merged, I spoke with @ia3andy and he confirmed that the latest version will be also used in temporary instances.

https://code.quarkus.redhat.com was updated to have presets
New pageLoadedSelector was identified to work with old and new version
validatePresenceOfSupportedFlags now checks grpc extension URL because the default page has presets without a visible list of extensions
@rsvoboda rsvoboda requested a review from jedla97 October 30, 2024 08:51
Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! CI passing, merging.

@jedla97 jedla97 merged commit fff5ec7 into quarkus-qe:main Oct 30, 2024
9 checks passed
@ia3andy
Copy link

ia3andy commented Oct 30, 2024

Thanks @rsvoboda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants