Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Run Java versions validation against 3.2 stream #394

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

gtroitsk
Copy link
Member

@gtroitsk gtroitsk commented Sep 10, 2024

Fix failures detected in #393

https://code.quarkus.redhat.com/?S=com.redhat.quarkus.platform%3A3.2 page should be used in validatePresenceOfJavaVersionSelect test to retrieve correct information about current supported Java versions

@gtroitsk gtroitsk marked this pull request as draft September 11, 2024 07:53
@rsvoboda
Copy link
Member

rsvoboda commented Sep 11, 2024

Test that failed was public void validatePresenceOfJavaVersionSelect(TestInfo testInfo), this doesn't fix it, stream is already added in https://github.com/quarkus-qe/quarkus-startstop/pull/320/files

The failure is

Error:  Tests run: 7, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 20.264 s <<< FAILURE! - in io.quarkus.ts.startstop.CodeQuarkusSiteTest
Error:  validatePresenceOfJavaVersionSelect{TestInfo}  Time elapsed: 1.011 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: Java 11 is missing in java version select! javaVersionText: 1721 ==> expected: <true> but was: <false>
	at io.quarkus.ts.startstop.CodeQuarkusSiteTest.validatePresenceOfJavaVersionSelect(CodeQuarkusSiteTest.java:105)"

You should amend + "?S=com.redhat.quarkus.platform%3A3.2" in the test otherwise you face side effects like in the CI runs.

@gtroitsk gtroitsk marked this pull request as ready for review September 11, 2024 22:40
@gtroitsk gtroitsk changed the title [3.2] Ensure code quarkus web is pointing to 3.2 platform version [3.2] Run Java versions validation against 3.2 stream Sep 11, 2024
@rsvoboda rsvoboda merged commit e096956 into quarkus-qe:3.2 Sep 12, 2024
9 checks passed
@gtroitsk gtroitsk deleted the fix/tests-point-3.2-web branch September 12, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants