Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asciidoc warnings #156

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Fix asciidoc warnings #156

merged 2 commits into from
Aug 10, 2023

Conversation

TheJavaGuy
Copy link
Contributor

@TheJavaGuy TheJavaGuy commented Jul 26, 2023

Proof of all warnings gone:
image

Proof of warnings before this PR:
image

@gastaldi @vsevel when you have a bit of time please review :)

@gastaldi gastaldi requested a review from a team July 28, 2023 15:13
@TheJavaGuy
Copy link
Contributor Author

@kdubb I think you must merge, I don't have the rights.

@gsmet
Copy link
Member

gsmet commented Aug 10, 2023

@TheJavaGuy btw, thanks for all your work on the Quarkiverse guides. Very much appreciated!

@TheJavaGuy
Copy link
Contributor Author

Hey @gsmet thanks a lot for your kind words! All of you guys are doing an amazing work on Quarkus and the whole ecosystem, this is the least I could do to help (and maybe inspire someone else to start contributing).

@vsevel vsevel merged commit ab6676c into quarkiverse:main Aug 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants