Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instanciate parser with a LocalContentResolver #139

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Instanciate parser with a LocalContentResolver #139

merged 1 commit into from
Nov 4, 2024

Conversation

jtama
Copy link
Member

@jtama jtama commented Nov 4, 2024 •
edited
Loading

Fixes #138

@jtama jtama requested a review from a team as a code owner November 4, 2024 11:22
ia3andy
ia3andy approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ia3andy
Copy link
Contributor

ia3andy commented Nov 4, 2024

@mkouba I let you merge this patch

@jtama
Copy link
Member Author

jtama commented Nov 4, 2024 •
edited
Loading

Thanks to @ia3andy, we have a workaround by using qute includes instead of asciidoc one.

I let you decide wether to close or merge the PR.
I think a NullPointerException is never a good sign.

@mkouba
Copy link
Contributor

mkouba commented Nov 4, 2024

I have to admit that I don't have enough context but I agree that we should avoid NullPointerExceptions where possible.

@mkouba mkouba merged commit 52ff6c1 into quarkiverse:main Nov 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asciidoc converter prevent the use of includes
3 participants
@jtama @ia3andy @mkouba