Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse BucketConfiguration #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

reuse BucketConfiguration #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions runtime/src/main/java/io/quarkiverse/bucket4j/runtime/BucketPodStorageRecorder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
public class BucketPodStorageRecorder {

private final RateLimiterRuntimeConfig config;

Map<String, BucketConfiguration> podsConfigurations = new HashMap<>();
Map<MethodDescription, BucketPod> pods = new HashMap<>();

public BucketPodStorageRecorder(RateLimiterRuntimeConfig config) {
Expand All @@ -24,20 +26,27 @@ public BucketPodStorageRecorder(RateLimiterRuntimeConfig config) {

private BucketPod getBucketPod(MethodDescription methodDescription, String key,
String identityResolverClassName) {

Bucket bucketConfig = config.buckets().get(key);
if (bucketConfig == null) {
throw new IllegalStateException("missing limits config for " + key);
}
ConfigurationBuilder builder = BucketConfiguration.builder();
for (Limit limit : bucketConfig.limits()) {
builder.addLimit(Bandwidth.builder()
.capacity(limit.permittedUses())
.refillGreedy(limit.permittedUses(), limit.period())
.build());
}

BucketConfiguration podConfig = podsConfigurations.computeIfAbsent(key, (k) -> {
if (bucketConfig == null) {
throw new IllegalStateException("missing limits config for " + key);
}
ConfigurationBuilder builder = BucketConfiguration.builder();
for (Limit limit : bucketConfig.limits()) {
builder.addLimit(Bandwidth.builder()
.capacity(limit.permittedUses())
.refillGreedy(limit.permittedUses(), limit.period())
.build());
}
return builder.build();
});

String id = bucketConfig.shared() ? key : key + methodDescription.hashCode();

try {
return new BucketPod(id, builder.build(),
return new BucketPod(id, podConfig,
(Class<? extends IdentityResolver>) Thread.currentThread().getContextClassLoader()
.loadClass(Optional.ofNullable(identityResolverClassName).orElse(bucketConfig.identityResolver())));
} catch (ClassNotFoundException e) {
Expand Down