Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dependabot ignore patch updates to JS dependencies #6967

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Jan 21, 2025

This PR is in response to issue #6966.

It seems like the greatest number of Dependabot PR spam comes from the JavaScript dependencies for cirq-web. This change to the "npm" Dependabot config to make it group minor and/or patch version updates into a single PR if they are not security-related changes; all other updates (meaning, any security updates, and any major version updates) will be handled using the default method, which is separate PRs.

This groups configuration is based on an example in the Dependabot documentation.

With respect to this week's Dependabot activity, this configuration would only have affected the one for ts-loader; the others were all major version changes, and (unfortunately for us) probably should remain as individual PRs so they can be checked by a human.

It seems like the greatest number of Dependabot PR spam comes from the
JavaScript dependencies for cirq-web. This change to the "npm"
Dependabot config makes it group minor and/or patch version updates
into a single PR if they are not security-related changes; all other
updates (meaning, any security updates, and any major version updates)
will be handled using the default method, which is separate PRs.

This `groups` configuration is based on [an example in the Dependabot
documentation](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/optimizing-pr-creation-version-updates#example-3-individual-pull-requests-for-major-updates-and-grouped-for-minorpatch-updates).
@CirqBot CirqBot added the Size: XS <10 lines changed label Jan 21, 2025
@mhucka mhucka requested a review from pavoljuhas January 21, 2025 20:06
@mhucka mhucka self-assigned this Jan 21, 2025
@mhucka mhucka marked this pull request as ready for review January 21, 2025 20:08
@mhucka mhucka requested review from vtomole and a team as code owners January 21, 2025 20:08
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (9945db6) to head (0fe8c2c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6967   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files        1082     1082           
  Lines       94762    94762           
=======================================
+ Hits        92746    92752    +6     
+ Misses       2016     2010    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mhucka mhucka added this pull request to the merge queue Jan 21, 2025
Merged via the queue into quantumlib:main with commit 62c72dd Jan 21, 2025
37 checks passed
@mhucka mhucka deleted the mhucka-adjust-dependabot-config branch January 21, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants