Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stats #39

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Fix stats #39

merged 4 commits into from
Jun 3, 2024

Conversation

lucasberent
Copy link
Collaborator

fix stats reset problems for lsd

* fix resetting at each decoding run for bplsd, also if BP converges
@lucasberent lucasberent changed the base branch from main to l4_dev May 20, 2024 19:28
for i in range(self.n): out[i] = self.bpd.decoding[i]
for i in range(self.n):
out[i] = self.bpd.decoding[i]
self.lsd.reset_cluster_stats()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are stats run all the time? Does this have a noticeable impact on runtime?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just to ensure that if the decoder is run and BP converges (LSD is not called at all) and then the cluster stats are read, that they do not contain old information.

@lucasberent lucasberent merged commit 4ad8af3 into l4_dev Jun 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants