Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a note on extracting multiline processing in comprehensions #148

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

graingert
Copy link
Contributor

follow up to #135

def cond(v): ...

[process(x) for x in items if cond(v)] # preferable to map(process, filter(cond, items))

Copy link
Contributor Author

@graingert graingert Feb 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about also a note on how to combine cond and process?

Sometimes a condition or process may repeat computation unnecessarily, in those cases extract a function that returns an iterable with the result or an empty iterable:

.. code:: python
    hams = [x["ham"] for x in items if "ham" in x]  # duplicate key lookup

.. code:: python
    def process(x):
        try:
            return (x["ham"],)
        except KeyError:
            return ()

    hams = [ham for x in items for ham in process(x)]

Copy link
Contributor Author

@graingert graingert Feb 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also often possible to inline this empty iterable into the comprehension

.. code:: python
    hams = [x["ham"] for x in items if x.get("ham") is not None]  # duplicated key lookup

.. code:: python
    hams = [
        ham
        for x in items
        for ham in (x.get("ham"),)
        if ham is not None
    ]

and alternative in python 3.8+ is

.. code:: python
    hams = [
        ham
        for x in items
        if (ham := x.get("ham")) is not None
    ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant