Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #17

wants to merge 1 commit into from

Conversation

gianpo86
Copy link

@gianpo86 gianpo86 commented Nov 5, 2023

Add docker compose example and update extended docker run command with current version of the image

Add docker compose example and update extended docker run command with current version of the image
### Example with docker componse:
```
version: '3.3'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meanwhile the version in docker-compose files is obsolete, so it can/should be removed.

- CUPSPASSWORD=<password>
ports:
- 631:631

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Published ports are discarded when using host network mode.

Copy link

@peterlang-p peterlang-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally I would prefer to have the docker-compose sample in sync with the docker-compose.yml in the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants