Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

feat: Adds permission check shortcut using repo.installed_by #33

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Nov 8, 2023

This PR adds a way to check permission using installed_by (because it has already been approved).

@frgfm frgfm added the type: improvement New feature or request label Nov 8, 2023
@frgfm frgfm added this to the 0.1.0 milestone Nov 8, 2023
@frgfm frgfm self-assigned this Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b7efdf0) 86.42% compared to head (0057e32) 86.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   86.42%   86.42%           
=======================================
  Files          27       27           
  Lines         766      766           
=======================================
  Hits          662      662           
  Misses        104      104           
Flag Coverage Δ
unittests 86.42% <62.50%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/app/services/github.py 89.13% <100.00%> (ø)
src/app/api/api_v1/endpoints/repos.py 94.91% <66.66%> (ø)
src/app/api/api_v1/endpoints/guidelines.py 82.97% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frgfm frgfm merged commit 00e9192 into main Nov 8, 2023
9 of 10 checks passed
@frgfm frgfm deleted the permission-optimize branch November 8, 2023 13:40
frgfm added a commit that referenced this pull request Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant