Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

refactor: Refactors GitHub interactions & adds unit tests #27

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Nov 7, 2023

This PR introduces the following modifications:

  • refactors github interactions into the github client
  • adds safeguard on guideline reordering
  • updates unittests

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (3d462ec) 83.21% compared to head (cbc3cbf) 84.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   83.21%   84.97%   +1.75%     
==========================================
  Files          27       27              
  Lines         703      712       +9     
==========================================
+ Hits          585      605      +20     
+ Misses        118      107      -11     
Flag Coverage Δ
unittests 84.97% <82.00%> (+1.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/app/api/api_v1/endpoints/repos.py 88.46% <100.00%> (+10.03%) ⬆️
src/app/core/config.py 94.23% <ø> (-0.11%) ⬇️
src/app/schemas/login.py 100.00% <ø> (ø)
src/app/schemas/services.py 100.00% <100.00%> (ø)
src/app/api/api_v1/endpoints/login.py 65.11% <62.50%> (-0.19%) ⬇️
src/app/services/github.py 82.92% <80.00%> (+25.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frgfm frgfm merged commit 8f05a7a into main Nov 7, 2023
9 of 10 checks passed
@frgfm frgfm deleted the github-fix branch November 7, 2023 14:45
frgfm added a commit that referenced this pull request Mar 28, 2024
* feat: Make guideline view disappear when logged out

* fix: Fixes selectionrange

* feat: Improves diagnostic display

* style: Fixes formatting
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant