Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

feat(router): make the router immune to missing trailing slashes #148

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Apr 5, 2024

This PR ensures requests are redirected to the endpoint with trailing slashes to avoid unnecessary 404 response.

@frgfm frgfm added the type: improvement New feature or request label Apr 5, 2024
@frgfm frgfm added this to the 0.1.0 milestone Apr 5, 2024
@frgfm frgfm self-assigned this Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (84c21f7) to head (8f5edf1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files          29       29           
  Lines         917      917           
=======================================
  Hits          769      769           
  Misses        148      148           
Flag Coverage Δ
unittests 83.86% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frgfm frgfm merged commit 0225b63 into main Apr 5, 2024
19 checks passed
@frgfm frgfm deleted the redirect-slashes branch April 5, 2024 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ext: scripts type: improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant